Minor: Add additional coalesce tests #10334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
alamb
commented
May 1, 2024
| @@ -0,0 +1,374 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
Given the size of these tests I opted to put them in their own file rather than function.slt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #10261
Rationale for this change
@jayzhan211 's great PR here #10268 added new tests and potentially changed behavior of
coalescewith respect to dictionaries, revealing a test gapWhat changes are included in this PR?
Port the great tests that @jayzhan211 made in #10268. Merging these before #10268 will both increase test coverage, decrease the size of the diff in #10268 and make it easier to understand what behavior has changed.
Are these changes tested?
All tests
Are there any user-facing changes?
No