Minor: Do not force analyzer to copy logical plans #10367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
May 3, 2024
| @@ -1864,7 +1864,7 @@ impl SessionState { | |||
|
|
|||
| // analyze & capture output of each rule | |||
| let analyzer_result = self.analyzer.execute_and_check( | |||
| e.plan.as_ref(), | |||
| e.plan.as_ref().clone(), | |||
There was a problem hiding this comment.
This is where the cloning happens now (at the callsite)
| @@ -115,7 +115,7 @@ impl Analyzer { | |||
| /// do necessary check and fail the invalid plans | |||
| pub fn execute_and_check<F>( | |||
| &self, | |||
| plan: &LogicalPlan, | |||
| plan: LogicalPlan, | |||
There was a problem hiding this comment.
This is the API change and the clone is removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this has 4 lines of code change and the rest are test updates to remove
&)Which issue does this PR close?
Part of #9637
Rationale for this change
The current
Analyzer::execute_and_checkAPI requires cloning aLogicalPlanWhat changes are included in this PR?
Analyzer::execute_and_checkto take an owned plan (and thus the caller to do the clone if they don't have one)Are these changes tested?
CI
Note I expect this to have a limited impact on performance as the higher level APIs (e.g.
SessionState::optimizestill take a&LogicalPlan) but at least the lower level APIs wontAre there any user-facing changes?