Minor: Move group accumulator for aggregate function to physical-expr-common, and add ahash physical-expr-common #10574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
github-actions
bot
added
logical-expr
Signed-off-by: jayzhan211 <[email protected]>
alamb
approved these changes
May 21, 2024
| @@ -59,6 +59,9 @@ version = "38.0.0" | |||
| # for the inherited dependency but cannot do the reverse (override from true to false). | |||
| # | |||
| # See for more detaiils: https://github.com/rust-lang/cargo/issues/11329 | |||
| ahash = { version = "0.8", default-features = false, features = [ | |||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| pub mod accumulate; |
There was a problem hiding this comment.
Perhaps we could add a note that this module is for implementing GroupsAccumulator
Suggested change
| pub mod accumulate; | |
| //! Utilities for implementing [`GroupsAccumulator`] | |
| pub mod accumulate; |
| mod adapter; | ||
| pub use accumulate::NullState; | ||
|
|
There was a problem hiding this comment.
👍 for backwards compatibility
Maybe we can leave a comment explaining it is for backwards compatibility
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
|
Thanks @alamb |
|
🚀 |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…-common, and add ahash physical-expr-common (apache#10574) * ahash workspace Signed-off-by: jayzhan211 <[email protected]> * move other utils Signed-off-by: jayzhan211 <[email protected]> * move NullState Signed-off-by: jayzhan211 <[email protected]> * move PrimitiveGroupsAccumulator Signed-off-by: jayzhan211 <[email protected]> * move boolop Signed-off-by: jayzhan211 <[email protected]> * move deciamlavg Signed-off-by: jayzhan211 <[email protected]> * add comment Signed-off-by: jayzhan211 <[email protected]> * fix doc Signed-off-by: jayzhan211 <[email protected]> --------- Signed-off-by: jayzhan211 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Counttofunctions-aggregate, update MSRV to rust 1.75 #10484What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?