Minor: Consolidate some integration tests into core_integration
#10588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
May 20, 2024
| @@ -1,308 +0,0 @@ | |||
| // Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
This was moved to custom_sources_cases.mod
|
Thank you for the review @jonahgao |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…ache#10588) * Consolidate custom_sources test into core_integration * Consolidate simplification into core_integration * Consolidate memory_limit and fifo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
In an effort to make it faster to develop and test datafusion , it would be nice if the resources required to run the tests were smaller
For example, on my machine, simply running the
memory_limitintegration testcargo test --test memory_limitRequires creating / linking a 148 MB binary:
andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion2$ du -s -h target/debug/deps/memory_limit-47b8096a6ecbd81c 148M target/debug/deps/memory_limit-47b8096a6ecbd81cWhile creating the
core_integrationtest requires 151MNot only does each integration test target require about 140MB of extra space and the time to link, it also slows down the tests runs as they are not run in parallel with other tests
What changes are included in this PR?
memory_limit,fifo,custom_sourcesandsimplificationtests into thecore_integrationtestAfter this PR
core_integrationis 2MB larger:andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion2$ du -s -h target/debug/deps/core_integration-2ccc5be60db1701a 153M target/debug/deps/core_integration-2ccc5be60db1701aSo this PR saves creating roughly 600MB of binaries for testing
Are these changes tested?
They are all tests
Are there any user-facing changes?
No this is a developer productivity one only