Minor: Remove clone in optimizer #11315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
alamb
approved these changes
Jul 7, 2024
| let new_join = Arc::new(LogicalPlan::Join(Join { | ||
| left: Arc::new((*join.left).clone()), | ||
| right: Arc::new((*join.right).clone()), | ||
| left: join.left, |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* rm clone Signed-off-by: jayzhan211 <[email protected]> * outer join + fix test Signed-off-by: jayzhan211 <[email protected]> --------- Signed-off-by: jayzhan211 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4628 and #9637
Closes #.
Rationale for this change
There are still clones left to be removed
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?