-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datafusion.catalog.has_headers
default value set to true
#11919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in draft since I'm going to check if changing default value of |
73c6024
to
575c4b7
Compare
575c4b7
to
bd85173
Compare
datafusion.catalog.has_headers
default value set to true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @korowa - I think this is a great step forward in usability personally.
Perhaps you can try to merge this PR yourself as a test of having the committer configuration setup correctly 🤔
Marking the PR as API change to get it some addtional visibility in documentation |
🚀 |
Which issue does this PR close?
Closes #11848.
Closes #11936.
Rationale for this change
Making
datafusion.catalog.has_headers
consistent with defaultCsvReadOptions
/WriterBuilder
has_header values.What changes are included in this PR?
datafusion.catalog.has_header
changed to Trueinsert
statements)Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
Statements involving external CSV tables now write / try to read header row as a default behavior.