Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse bulk serialization helpers for protobuf #12179

Conversation

findepi
Copy link
Member

@findepi findepi commented Aug 26, 2024

Reuse parse_exprs and serialize_exprs. Reduce code duplication, increasing readability.

Prep for Extracted from #12177

Reuse `parse_exprs` and `serialize_exprs`. Reduce code duplication,
increasing readability.
@github-actions github-actions bot added the proto Related to proto crate label Aug 26, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a nice improvement in code quality to me. Thank you @findepi

@alamb alamb merged commit bf46f33 into apache:main Aug 27, 2024
25 checks passed
@findepi findepi deleted the findepi/reuse-bulk-serialization-helpers-for-protobuf-1d1e35 branch August 27, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proto Related to proto crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants