Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable needless_pass_by_value clippy lint #12243

Closed
wants to merge 1 commit into from
Closed

Enable needless_pass_by_value clippy lint #12243

wants to merge 1 commit into from

Conversation

findepi
Copy link
Member

@findepi findepi commented Aug 29, 2024

Relates to #12197 (comment)

@findepi findepi marked this pull request as draft August 29, 2024 21:05
@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Physical Expressions optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) substrait common Related to common crate execution Related to the execution crate proto Related to proto crate functions labels Aug 29, 2024
@findepi
Copy link
Member Author

findepi commented Aug 29, 2024

draft -- waits for #12242 & #12207

@findepi
Copy link
Member Author

findepi commented Aug 29, 2024

Relates to #12197 (comment)

cc @crepererum

@findepi findepi force-pushed the findepi/needless_pass_by_value branch from 6528d96 to 731b64b Compare August 29, 2024 21:06
@findepi findepi mentioned this pull request Aug 29, 2024
Merged
@crepererum
Copy link
Contributor

could you try to factor out the API changes into separate PRs? This would make the reviews and the changelog generation a bit easier.

@findepi findepi force-pushed the findepi/needless_pass_by_value branch from 731b64b to 69bc660 Compare August 30, 2024 11:37
This was referenced Aug 30, 2024
Merged
Merged
Merged
@findepi findepi force-pushed the findepi/needless_pass_by_value branch from 69bc660 to 978f0b5 Compare August 30, 2024 13:03
@findepi
Copy link
Member Author

findepi commented Aug 30, 2024

could you try to factor out the API changes into separate PRs? This would make the reviews and the changelog generation a bit easier.

good call!

extracted these for now

@findepi findepi force-pushed the findepi/needless_pass_by_value branch from 978f0b5 to 59d0bcd Compare September 6, 2024 18:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale PR has not had any activity for some time label Nov 6, 2024
@findepi findepi closed this Nov 6, 2024
@findepi findepi deleted the findepi/needless_pass_by_value branch November 6, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
common Related to common crate core Core DataFusion crate execution Related to the execution crate functions logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Physical Expressions proto Related to proto crate sql SQL Planner sqllogictest SQL Logic Tests (.slt) Stale PR has not had any activity for some time substrait
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@findepi @crepererum