Add RuntimeEnv::try_new and deprecate RuntimeEnv::new
#12566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Sep 21, 2024
There was a problem hiding this comment.
Thank you @OussamaSaoudi -- I have kicked off the CI tests for this one
| @@ -66,8 +66,12 @@ impl Debug for RuntimeEnv { | |||
| } | |||
|
|
|||
| impl RuntimeEnv { | |||
| /// Create env based on configuration | |||
| #[deprecated(note = "please use `try_new` instead")] | |||
alamb
approved these changes
Sep 21, 2024
There was a problem hiding this comment.
👨🍳 👌
Very nice @OussamaSaoudi -- looks great to me.
I am surprised this didn't cause any other changes
alamb
changed the title
RuntimeEnv::try_new and deprecate RuntimeEnv::new
|
Thanks again @OussamaSaoudi |
|
Thanks for the clear and beginner friendly issues @alamb! This was a great way to get introduced to the code, and I'm looking forward to contributing more :D |
You are welcome -- and I am glad the tickets fulfilled their intended purpose |
bgjackma
pushed a commit
to bgjackma/datafusion
that referenced
this pull request
Sep 25, 2024
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion-python
that referenced
this pull request
Oct 15, 2024
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion-python
that referenced
this pull request
Oct 28, 2024
Michael-J-Ward
added a commit
to apache/datafusion-python
that referenced
this pull request
Nov 10, 2024
* patch datafusion deps * migrate from deprecated RuntimeEnv::new to RuntimeEnv::try_new Ref: apache/datafusion#12566 * remove Arc from create_udf call Ref: apache/datafusion#12489 * doc typo * migrage new UnnestOptions API Ref: https://github.com/apache/datafusion/pull/12836/files * update API for logical expr Limit Ref: apache/datafusion#12836 * remove logical expr CrossJoin It was removed upstream. Ref: apache/datafusion#13076 * update PyWindowUDF Ref: apache/datafusion#12803 * migrate window functions lead and lag to udwf Ref: apache/datafusion#12802 * migrate window functions rank, dense_rank, and percent_rank to udwf Ref: apache/datafusion#12648 * convert window function cume_dist to udwf Ref: apache/datafusion#12695 * convert window function ntile to udwf Ref: apache/datafusion#12694 * clean up functions_window invocation * Only one column was being passed to udwf * Update to DF 43.0.0 * Update tests to look for string_view type * String view is now the default type for strings * Making a variety of adjustments in wrappers and unit tests to account for the switch from string to string_view as default * Resolve errors in doc building --------- Co-authored-by: Tim Saucer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12554
What changes are included in this PR?
RuntimeEnv::newtoRuntimeEnv::try_newRuntimeEnv::newin code and documentation to useRuntimeEnv::try_newAre these changes tested?
No extra tests required. Ensured that compilation, existing tests, and doc tests pass.
Are there any user-facing changes?
None.