Make SessionContext::enable_url_table consume self #12573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Sep 21, 2024
| @@ -64,7 +64,7 @@ async fn main() -> Result<()> { | |||
| df.show().await?; | |||
|
|
|||
| // dynamic query by the file path | |||
| ctx.enable_url_table(); | |||
| let ctx = ctx.enable_url_table(); | |||
There was a problem hiding this comment.
this example actually has the exact same bug I hit in #12551 -- namely the returned ctx has the table enabled, not the current one.
There was a problem hiding this comment.
Thanks for reminding this bug!
| pub fn enable_url_table(&self) -> Self { | ||
| let state_ref = self.state(); | ||
| pub fn enable_url_table(self) -> Self { | ||
| let current_catalog_list = Arc::clone(self.state.read().catalog_list()); |
There was a problem hiding this comment.
this avoids copying the entire state just to copy the catalog list
| Arc::clone(&factory) as Arc<dyn UrlTableFactory>, | ||
| )); | ||
| let new_state = SessionStateBuilder::new_from_existing(self.state()) | ||
| let ctx: SessionContext = self |
There was a problem hiding this comment.
This is likely just my obsession with trying to have clear Builder style APIs, but I think it reads more clearly here to to back and forth between the types
andygrove
approved these changes
Sep 21, 2024
goldmedal
approved these changes
Sep 22, 2024
| @@ -64,7 +64,7 @@ async fn main() -> Result<()> { | |||
| df.show().await?; | |||
|
|
|||
| // dynamic query by the file path | |||
| ctx.enable_url_table(); | |||
| let ctx = ctx.enable_url_table(); | |||
There was a problem hiding this comment.
Thanks for reminding this bug!
|
Thanks @andygrove and @goldmedal |
bgjackma
pushed a commit
to bgjackma/datafusion
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes #12551
Rationale for this change
As described on #12551 the current non consuming API was confusing and caused silently ignored bugs
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?