-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DictionaryString for Regex matching operators #12768
Merged
Merged
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3bcad73
Do not optimise regex casts in `UnwrapCastInComparison`
blaginin 5c1aef0
Mark regex operators are non-comparison ones
blaginin 28c172f
Also remove is distinct from
blaginin 591279d
Rename method for `supports_propagation` for clarity
blaginin 4cdee55
Remove duplicated tests
blaginin aaca653
Fix doctest
blaginin 46050a7
Merge branch 'main' into fix-dict-string-regex-match
blaginin 3236f70
Merge branch 'refs/heads/main' into fix-dict-string-regex-match
blaginin b95640d
Revert `supports_propagation` and handle dicts in `binary_string_arra…
blaginin 2c5b79e
Update tabulation
blaginin a1d2cd5
Minimise code inside `downcast_dictionary_array!` to fix wasm-pack build
blaginin 5661700
Switch to `as_any_dictionary`
blaginin 7698328
Merge branch 'main' into fix-dict-string-regex-match
blaginin 9667665
Use `take_iter`
blaginin ad4f43d
Merge branch 'main' into fix-dict-string-regex-match
blaginin be39ac3
Revert `is_comparison_operator` and make it deprecated
blaginin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍