fix: planning of prepare statement with limit clause #13088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgao
commented
Oct 24, 2024
| @@ -88,10 +90,10 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { | |||
| let empty_schema = DFSchema::empty(); | |||
|
|
|||
| let skip = skip | |||
| .map(|o| self.sql_to_expr(o.value, &empty_schema, &mut PlannerContext::new())) | |||
| .map(|o| self.sql_to_expr(o.value, &empty_schema, planner_context)) | |||
There was a problem hiding this comment.
We should use the existing PlannerContext that includes prepare_param_data_types, instead of creating an empty one.
alamb
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Thank you @jonahgao -- this is a great find and a very nice fix
FYI @WeCodingNow
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12294.
Rationale for this change
This PR enables creating logical plan for a prepare statement with a limit clause.
Creating physical plan for prepare is not yet supported and is being tracked in #4539.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No