Core: Fix incorrect searched CASE optimization #14349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an optimization for searched CASE where values are of boolean type. It was converting the expression like
into
This had the following problems
X IS DISTINCT FROM true
(NULL AND ..) OR (NULL AND ..) OR (false)
which is NULL, not falseX
for truthness check ofX
, we need to testX IS NOT DISTINCT FROM true
This commit fixes that optimization.