Consolidate decimal error checking and improve error messages #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datafusion
liukun4515
reviewed
Dec 13, 2021
| ))); | ||
| } | ||
| (Some(p), Some(s)) => { | ||
| // Arrow decimal is i128 meaning 38 maximum decimal digits |
houqp
approved these changes
Dec 13, 2021
mcheshkov
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Aug 23, 2024
Can drop this after rebase on commit 4b454d0, first released in 7.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
As suggested by @Dandandan and @liukun4515, there is a bit of duplication and an error message mismatch: https://github.com/apache/arrow-datafusion/pull/1431/files#r766728006
Changes
Pull decimal precision error checking into a siingle function