Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indented display for multi-child nodes #358

Merged
merged 1 commit into from
May 19, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 19, 2021

Which issue does this PR close?

Closes #345

Rationale for this change

When generating display output, the indent level of nodes with more than one child input was not correct.

Note the code with the bug has not yet been released yet

@codecov-commenter
Copy link

Codecov Report

Merging #358 (d9b1b85) into master (aa26112) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
+ Coverage   75.84%   75.86%   +0.01%     
==========================================
  Files         143      143              
  Lines       23809    23824      +15     
==========================================
+ Hits        18059    18075      +16     
+ Misses       5750     5749       -1     
Impacted Files Coverage Δ
datafusion/src/physical_plan/display.rs 86.66% <100.00%> (+2.05%) ⬆️
datafusion/tests/sql.rs 99.89% <100.00%> (+<0.01%) ⬆️
datafusion/src/physical_plan/mod.rs 82.35% <0.00%> (-2.36%) ⬇️
datafusion/src/physical_plan/hash_join.rs 86.05% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa26112...d9b1b85. Read the comment docs.

@alamb
Copy link
Contributor Author

alamb commented May 19, 2021

fyi @andygrove

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Dandandan Dandandan merged commit 2f73558 into apache:master May 19, 2021
@alamb alamb added the datafusion Changes in the datafusion crate label May 19, 2021
@alamb alamb deleted the fix-indent-for-hash branch May 19, 2021 18:57
@houqp houqp added the bug Something isn't working label Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indentation is incorrect for joins in formatted physical plans
5 participants