Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for xz file compression and compression feature #3993

Merged
merged 2 commits into from
Nov 25, 2022
Merged

add support for xz file compression and compression feature #3993

merged 2 commits into from
Nov 25, 2022

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Oct 28, 2022 •
edited
Loading

Which issue does this PR close?

Rationale for this change

add support for xz file compression

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner labels Oct 28, 2022
alamb
alamb approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change to me 👍

The only thing I worry about is the new dependency. Not sure if it is worth making optional or not now

datafusion-cli/Cargo.lock
@@ -2702,6 +2715,15 @@ dependencies = [
"winapi",
]

[[package]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for anyone following along, xz is now a new dependency

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe worth creating an optional feature?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I wonder if we should make a feature for "support compression" as a similar argument could be made for bzip, etc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feature gate added

@jimexist jimexist mentioned this pull request Oct 31, 2022
Merged
@alamb alamb changed the title add support for xz file compression add support for xz file compression and compression feature Nov 1, 2022
alamb
alamb reviewed Nov 1, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimexist

datafusion/core/Cargo.toml Outdated Show resolved Hide resolved
@alamb alamb mentioned this pull request Nov 1, 2022
Closed
@jimexist jimexist force-pushed the add-support-for-xz branch 3 times, most recently from 52ccbe9 to 9d4028b Compare November 3, 2022 11:39
alamb
alamb approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thanks @jimexist

.github/workflows/rust.yml Outdated
@@ -98,7 +98,7 @@ jobs:
- name: Run tests
run: |
export PATH=$PATH:$HOME/d/protoc/bin
cargo test --features avro,jit,scheduler,json
cargo test --features avro,jit,scheduler,json,compression
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jimexist jimexist force-pushed the add-support-for-xz branch 2 times, most recently from 3032946 to d3f6057 Compare November 11, 2022 03:34
jimexist
jimexist commented Nov 11, 2022
View reviewed changes
datafusion/core/Cargo.toml Outdated
@@ -41,12 +41,13 @@ path = "src/lib.rs"
# Used to enable the avro format
avro = ["apache-avro", "num-traits", "datafusion-common/avro"]
crypto_expressions = ["datafusion-physical-expr/crypto_expressions"]
default = ["crypto_expressions", "regex_expressions", "unicode_expressions"]
default = ["compression", "crypto_expressions", "regex_expressions", "unicode_expressions"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alamb turns out it's harder than just putting it into the default features

jimexist
jimexist commented Nov 11, 2022
View reviewed changes
datafusion/core/Cargo.toml Outdated Show resolved Hide resolved
jimexist
jimexist commented Nov 11, 2022
View reviewed changes
ci/scripts/rust_clippy.sh Outdated Show resolved Hide resolved
jimexist
jimexist commented Nov 11, 2022
View reviewed changes
ci/scripts/rust_clippy.sh Outdated Show resolved Hide resolved
@alamb
Copy link
Contributor

alamb commented Nov 23, 2022

What happened with this PR? It appears to have some minor conflicts. @jimexist would you like help getting this through?

@jimexist
Copy link
Member Author

What happened with this PR? It appears to have some minor conflicts. @jimexist would you like help getting this through?

something broken about tests without compression feature enabled. turns out the simple fix is to just include it into default, which should be fine because they originally were enabled by default (not guarded by a feature gate).

@jimexist
Copy link
Member Author

@alamb this is ready to merge

@jimexist jimexist merged commit e34c6c3 into apache:master Nov 25, 2022
@jimexist jimexist deleted the add-support-for-xz branch November 25, 2022 14:19
@ursabot
Copy link

ursabot commented Nov 25, 2022

Benchmark runs are scheduled for baseline = 010aded and contender = e34c6c3. e34c6c3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb
Copy link
Contributor

alamb commented Nov 27, 2022

Thanks @jimexist !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add support for .xz compressed files add a feature gate to make support for compressed files optional
3 participants
@jimexist @alamb @ursabot