Split physical_plan_tpch into separate benchmarks #9043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
alamb
reviewed
Jan 29, 2024
There was a problem hiding this comment.
Hi @simonvandel -- thank you -- this makes sense to me
Could you please also have a single benchmark that runs them all (so that we also have an aggregate number, in addition to the breakdown by individual query)?
|
The clippy issue was fixed on main, so I think if you merge up from main the CI will pass |
|
Thanks again @simonvandel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relates to #8638
Rationale for this change
The
physical_plan_tpchbenchmark was taking a long time to run, without any feedback on the performance of each query.I think that splitting the benchmark up into a benchmark per query will allow better visibility into how code changes affect individual queries.
What changes are included in this PR?
Move
physical_plan_tpchbenchmark into multiplephysical_plan_tpch_{qn}benchmarks.Are these changes tested?
Yes, I have verified the benchmarks run.
Are there any user-facing changes?
No