chore(placeholder): update error message and add tests #9073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appletreeisyellow
changed the title
appletreeisyellow
changed the title
alamb
reviewed
Jan 31, 2024
There was a problem hiding this comment.
Thank you @appletreeisyellow -- I think this code is an improvement in that it documents what the current behavior is.
However, I am not sure if this resolves #8819, because I am not sure what @simonvandel is trying to do.
I am trying to clarify here #8819 (comment)
datafusion/core/tests/sql/select.rs
Outdated
| @@ -251,3 +251,63 @@ async fn test_parameter_invalid_types() -> Result<()> { | |||
| ); | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn test_parameter_empty_table_with_param_values() -> Result<()> { | |||
There was a problem hiding this comment.
Given these tests aren't SQL but use the DataFrame API they probably belong in https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests/dataframe instead
6 tasks
chore: add positive test and remove println
appletreeisyellow
force-pushed
the
chunchun/test-placeholder
branch
from
7858e01 to
3ad62dc
Compare
alamb
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relate to #8819
Rationale for this change
To help users use placeholder and parameter values
What changes are included in this PR?
No code change, only added tests
Are these changes tested?
Yes
Are there any user-facing changes?
No