Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement select directly from s3 and gcs locations in datafusion-cli #9199

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

r3stl355
Copy link
Contributor

Which issue does this PR close?

Closes #9167

Rationale for this change

This is a next step from #9150 adding ability to query directly from S3 and Google Storage

What changes are included in this PR?

Factored out the code from exec.rs into object_storage.rs to be re-usable.

Are these changes tested?

Adding a test for each storage type and a failing test for an invalid location

Are there any user-facing changes?

There are now more location types to query directly, also added docs with some examples

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great -- thank you so much @r3stl355 . Really nice refactor 🙏

@alamb alamb merged commit bd1c76c into apache:main Feb 13, 2024
23 checks passed
@alamb
Copy link
Contributor

alamb commented Feb 13, 2024

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to select directly from S3 and GCS locations in datafusion-cli
2 participants