Dont call multiunzip when no stats #9220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmturner
commented
Feb 13, 2024
| @@ -234,7 +234,7 @@ fn criterion_benchmark(c: &mut Criterion) { | |||
| let sql = std::fs::read_to_string(format!("../../benchmarks/queries/{}.sql", q)) | |||
| .unwrap(); | |||
| c.bench_function(&format!("physical_plan_tpch_{}", q), |b| { | |||
| b.iter(|| logical_plan(&ctx, &sql)) | |||
| b.iter(|| physical_plan(&ctx, &sql)) | |||
There was a problem hiding this comment.
There was disconnect between benchmark name (physical plan) and the function(logical plan), so I corrected this
Dandandan
approved these changes
Feb 13, 2024
alamb
approved these changes
Feb 14, 2024
| @@ -35,6 +35,7 @@ pub async fn get_statistics_with_limit( | |||
| all_files: impl Stream<Item = Result<(PartitionedFile, Statistics)>>, | |||
| file_schema: SchemaRef, | |||
| limit: Option<usize>, | |||
| collect_stats: bool, | |||
There was a problem hiding this comment.
Given the function is called 'get_statisticsand now there is a boolean flag that implies the stats aren't collected, can we please add some documentation to the docstring explaining what thecollect_stats` flag does?
There was a problem hiding this comment.
Yes good catch, will do.
|
@alamb I have updated the docstring. let me know if anything else |
|
Thanks again @matthewmturner ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9219
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?