Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: add a hint how to adjust max rows displayed #9845

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

comphead
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

I found it confusing as the user always looking into the code to find how to expand number of displayed rows.

What changes are included in this PR?

The formatted query execution refactored and looks like

100 row(s) fetched. (First 40 displayed. Use --maxrows to adjust)
Elapsed 0.014 seconds.

Are these changes tested?

Are there any user-facing changes?

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @comphead

@alamb
Copy link
Contributor

alamb commented Mar 29, 2024

Thank you -- I have tripped on this several times too

@alamb alamb merged commit 5ab5511 into apache:main Mar 29, 2024
23 checks passed
Lordworms pushed a commit to Lordworms/arrow-datafusion that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants