Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Return InternalError rather than panic for NamedStructField should be rewritten in OperatorToFunction #9968

Merged
merged 2 commits into from
Apr 6, 2024
Merged

Minor: Return InternalError rather than panic for NamedStructField should be rewritten in OperatorToFunction #9968

merged 2 commits into from
Apr 6, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Apr 5, 2024 •
edited
Loading

Which issue does this PR close?

N/A

Rationale for this change

When upgrading DataFusion internally we actually saw Panic's (due to a bug in our code):

level=error msg="Thread panic" panic_type=unknown panic_message="internal error: entered unreachable code: NamedStructField should be rewritten in OperatorToFunction" panic_file=/usr/local/cargo/git/checkouts/arrow-datafusion-cd9c4a788846b2bd/f16c211/datafusion/physical-expr/src/planner.rs panic_line=233 panic_column=21 target="panic_logging" location="panic_logging/src/lib.rs:54" time=1712340032101586067

What changes are included in this PR?

Convert the errors from panic to internal error

Are these changes tested?

No

Are there any user-facing changes?

@alamb alamb changed the title Minor: Return InternalError rather than panic for 'NamedStructField s… Minor: Return InternalError rather than panic for NamedStructField should be rewritten in OperatorToFunction Apr 5, 2024
@github-actions github-actions bot added the physical-expr Physical Expressions label Apr 5, 2024
jayzhan211
jayzhan211 approved these changes Apr 6, 2024
View reviewed changes
Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jayzhan211 jayzhan211 merged commit d201ec7 into apache:main Apr 6, 2024
24 checks passed
@alamb alamb deleted the alamb/no_panic branch April 6, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayzhan211 jayzhan211 jayzhan211 approved these changes

Assignees
No one assigned
Labels
physical-expr Physical Expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alamb @jayzhan211