Move LogicalPlan tree_node module
#9995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Apr 8, 2024
|
|
||
| //! Tree node implementation for logical expr and logical plan | ||
|
|
||
| pub mod expr; |
There was a problem hiding this comment.
It makes little sense to arrange the LogicalPlan tree node in datafuison/expr/src rather than datafusion/expr/src/logical_plan
There was a problem hiding this comment.
This is also consistent with how physical plan and physical expr are organized
https://github.com/search?q=repo%3Aapache%2Farrow-datafusion%20tree_node.rs&type=code
|
Thank you @jackwener 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #9994
Rationale for this change
The code is hard to find and hard to document
What changes are included in this PR?
Move the
LogicalPlantree node code out ofexprand intoLogicalPlan:Are these changes tested?
Yes, by existing tests
Are there any user-facing changes?
No