Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](cdc) configure table buckets for a single sink #307

Merged
merged 9 commits into from
Jan 31, 2024

Conversation

vinlee19
Copy link
Contributor

@vinlee19 vinlee19 commented Jan 24, 2024

Proposed changes

Issue Number: close #xxx

Problem Summary:

Describe the overview of changes.
Currently, when a single sink is enabled and CDC automatically creates a table, it fails to automatically set the number of buckets for the table based on the rules set by
--table-config table-buckets="table:bucketsNum,tablePrefix.*:num,.*:num"

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JNSimba JNSimba merged commit 007d524 into apache:master Jan 31, 2024
8 checks passed
@JNSimba JNSimba mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants