-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]support read ipv4/ipv6 type #365
Conversation
# Conflicts: # flink-doris-connector/src/main/java/org/apache/doris/flink/serialization/RowBatch.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -84,10 +88,10 @@ public void put(Object o) { | |||
} | |||
|
|||
// offset for iterate the rowBatch | |||
private int offsetInRowBatch = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove the initial value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove redundant initializer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
support read ipv4/ipv6 type since Apache Doris 2.1.1
Apache Doris supports IPv6 format, including IPv4-mapped format represented as
::ffff.255.255.255.255
and IPv4 to IPv6 conversion represented as::0.1.0.0
.Issue Number: close #xxx
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...