Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix the bug that the DorisTypeMapper datetime type will lose precision when converted to flink type #379

Merged
merged 1 commit into from
May 10, 2024

Conversation

huyuanfeng2018
Copy link
Contributor

@huyuanfeng2018 huyuanfeng2018 commented May 7, 2024

Proposed changes

Issue Number: close #378

Problem Summary:

#378

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@JNSimba
Copy link
Member

JNSimba commented May 7, 2024

Did you create the table through catalog?

@huyuanfeng2018
Copy link
Contributor Author

Did you create the table through catalog?

no, it was not created through flink doris catalog

@JNSimba
Copy link
Member

JNSimba commented May 7, 2024

How was that triggered? In theory, the catalog will reach this point

@huyuanfeng2018
Copy link
Contributor Author

How was that triggered? In theory, the catalog will reach this point

Then the doris table is created through the doris command and then written through flink
image
As shown in the figure, the stime field is at the millisecond level. I write it through flink.

USE CATALOG doris;
insert into doris.db,table xxx

The DorisCatalog#getTable method will return the mapping of the doris table to the flink table. The precision is not considered when processing the datetime type.

image

Copy link
Member

@JNSimba JNSimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JNSimba JNSimba merged commit 3b5d4ed into apache:master May 10, 2024
6 checks passed
@JNSimba JNSimba mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The DorisTypeMapper datetime type will lose precision when converted to flink type
2 participants