Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit API DELETE datasource (markAllSegmentsAsUnused) #15653

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Audit API DELETE datasource (markAllSegmentsAsUnused) #15653

merged 3 commits into from
Jan 11, 2024

Conversation

kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Jan 10, 2024 •
edited
Loading

Changes

  • Add audit for DELETE /druid/coordinator/v1/datasources/{datasourceName}
  • Minor renaming

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz
Copy link
Contributor Author

kfaraz commented Jan 11, 2024

Merging as failure is unrelated.

@kfaraz kfaraz merged commit f445ba4 into apache:master Jan 11, 2024
86 of 87 checks passed
@kfaraz kfaraz deleted the audit_mark_unused branch January 11, 2024 04:13
@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 29, 2024
@LakshSingla LakshSingla mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishekagarwal87 abhishekagarwal87 abhishekagarwal87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
29.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kfaraz @abhishekagarwal87 @LakshSingla