Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: hessian TagIdentifier supportting #issues-19 #25

Merged
merged 2 commits into from
May 13, 2019

Conversation

u0x01
Copy link
Contributor

@u0x01 u0x01 commented May 10, 2019

pojo.go Outdated Show resolved Hide resolved
pojo.go Outdated Show resolved Hide resolved
object_test.go Outdated Show resolved Hide resolved
pojo.go Outdated Show resolved Hide resolved
pojo.go Outdated Show resolved Hide resolved
Copy link
Contributor

@wongoo wongoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

小问题

@wongoo
Copy link
Contributor

wongoo commented May 10, 2019

tagIdentifier设置为空会不会有问题?

@u0x01
Copy link
Contributor Author

u0x01 commented May 13, 2019

tagIdentifier设置为空会不会有问题?

没什么影响,会 lookup 失败,相当于 tag 没作用了。
see more: https://github.com/golang/go/blob/2e4edf46977994c9d26df9327f0e41c1b60f3435/src/reflect/type.go#L1187

@wongoo wongoo merged commit efce029 into apache:master May 13, 2019
zhaoyunxing92 pushed a commit that referenced this pull request Sep 4, 2021
add: hessian TagIdentifier supportting #issues-19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants