-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.1] Fix group key in Nacos Service Discovery #10253
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.1 #10253 +/- ##
============================================
- Coverage 65.58% 65.57% -0.01%
Complexity 320 320
============================================
Files 1234 1234
Lines 53809 53809
Branches 8120 8121 +1
============================================
- Hits 35288 35286 -2
Misses 14691 14691
- Partials 3830 3832 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
请问这个对于那个pom文件呢 |
What is the purpose of the change
In Dubbo 2.7.x, the group value configured on the Nacos Registry URL is aligned with the group in the Nacos registry. (group can be used as a soft isolation similar to namespace)
In Dubbo 3.0.x, the group configured on the Nacos Registry URL is not used by default, and all use DEFAULT_GROUP. (group no longer provides isolation)
In Dubbo 3.1.x, the group value configured on the Nacos Registry URL will realign the group grouping in the Nacos registry.
Related docs apache/dubbo-website#1175
Brief changelog
Verifying this change
Checklist