Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1] Fix group key in Nacos Service Discovery #10253

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jul 1, 2022

What is the purpose of the change

In Dubbo 2.7.x, the group value configured on the Nacos Registry URL is aligned with the group in the Nacos registry. (group can be used as a soft isolation similar to namespace)

In Dubbo 3.0.x, the group configured on the Nacos Registry URL is not used by default, and all use DEFAULT_GROUP. (group no longer provides isolation)

In Dubbo 3.1.x, the group value configured on the Nacos Registry URL will realign the group grouping in the Nacos registry.

Related docs apache/dubbo-website#1175

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2022

Codecov Report

Merging #10253 (8d19256) into 3.1 (b5e7598) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##                3.1   #10253      +/-   ##
============================================
- Coverage     65.58%   65.57%   -0.01%     
  Complexity      320      320              
============================================
  Files          1234     1234              
  Lines         53809    53809              
  Branches       8120     8121       +1     
============================================
- Hits          35288    35286       -2     
  Misses        14691    14691              
- Partials       3830     3832       +2     
Impacted Files Coverage Δ
...he/dubbo/registry/nacos/NacosServiceDiscovery.java 56.52% <71.42%> (-0.30%) ⬇️
...ubbo/registry/nacos/NacosNamingServiceWrapper.java 50.00% <100.00%> (+6.52%) ⬆️
...o/registry/nacos/util/NacosNamingServiceUtils.java 80.70% <100.00%> (+0.34%) ⬆️
...dubbo/common/status/support/LoadStatusChecker.java 50.00% <0.00%> (-16.67%) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 62.79% <0.00%> (-9.31%) ⬇️
...e/dubbo/rpc/protocol/tri/transport/WriteQueue.java 73.80% <0.00%> (-4.77%) ⬇️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 67.59% <0.00%> (-2.78%) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.09% <0.00%> (-2.39%) ⬇️
...registry/zookeeper/util/CuratorFrameworkUtils.java 74.71% <0.00%> (-2.30%) ⬇️
...dubbo/rpc/cluster/directory/AbstractDirectory.java 80.39% <0.00%> (-1.97%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5e7598...8d19256. Read the comment docs.

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 2e5941f into apache:3.1 Jul 4, 2022
@TOP-LH
Copy link

TOP-LH commented Jul 23, 2022

请问这个对于那个pom文件呢

@AlbumenJ AlbumenJ added this to the 3.1.0 milestone Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants