Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix AbstractServiceDiscovery.update when doRegister first failed #14427

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

conghuhu
Copy link
Contributor

What is the purpose of the change

close #14126

Brief changelog

Verifying this change

see dubbo-registry/dubbo-registry-api/src/test/java/org/apache/dubbo/registry/client/ServiceDiscoveryCacheTest.java

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@conghuhu conghuhu requested a review from AlbumenJ July 12, 2024 13:44
@conghuhu conghuhu force-pushed the fix-refreshMetadataAndInstance branch from 1cec5ae to 3f33a8e Compare July 12, 2024 13:44
@conghuhu conghuhu requested a review from chickenlj July 12, 2024 13:45
@conghuhu conghuhu force-pushed the fix-refreshMetadataAndInstance branch 2 times, most recently from 5ca6b85 to 8f5a142 Compare July 12, 2024 13:48
@conghuhu conghuhu force-pushed the fix-refreshMetadataAndInstance branch from 8f5a142 to a40bad1 Compare July 12, 2024 14:42
Copy link

sonarcloud bot commented Jul 12, 2024

@conghuhu conghuhu added the type/bug Bugs to being fixed label Jul 15, 2024
Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit c0fec56 into apache:3.2 Jul 16, 2024
19 checks passed
@conghuhu conghuhu deleted the fix-refreshMetadataAndInstance branch July 16, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bugs to being fixed
Projects
None yet
3 participants