[#5507] feat(python): Support Azure blob storage for GVFS python client #5538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is not ready for review until #5508 is merged. |
yuqi1129
changed the title
yuqi1129
changed the title
|
@yuqi1129 can you please rebase PR. |
jerryshao
reviewed
Nov 21, 2024
| ops = infer_storage_options(storage_location) | ||
| if "username" not in ops or "host" not in ops or "path" not in ops: | ||
| raise GravitinoRuntimeException( | ||
| f"Storage location:{storage_location} doesn't support now. as the username," |
There was a problem hiding this comment.
"Username, host...are required"
| actual_prefix = f"{StorageType.ABS.value}://{ops['username']}@{ops['host']}{ops['path']}" | ||
|
|
||
| # For ABS, the actual path should be the same as the virtual path is like | ||
| # 'wasbs//[email protected]/test_gvfs_catalog6588/test_gvfs_schema/ |
There was a problem hiding this comment.
Why do we specify "wasbs"? Also what's the meaning here?
There was a problem hiding this comment.
I have removed the code here, the logic is specific for paths with wasbs prefixes.
jerryshao
reviewed
Nov 26, 2024
| f"Storage location:{storage_location} doesn't support now, the username," | ||
| f"host and path are required in the storage location." | ||
| ) | ||
| actual_prefix = f"{StorageType.ABS.value}://{ops['username']}@{ops['host']}{ops['path']}" |
There was a problem hiding this comment.
Should we add / before {ops['path']}?
There was a problem hiding this comment.
Actually not, please see L611, other file system like HDFS, file also omit the trialling slash.
There was a problem hiding this comment.
I mean "before", not "after".
There was a problem hiding this comment.
The value of path starts with /.
jerryshao
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support GVFS python client to access ADSL fileset.
Why are the changes needed?
This is a subsequent PR for #5508
Fix: #5507
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
IT locally.