[#5557] improvement(CI): Add some docs and tests about how to use Azure Blob Storage(ADLS) in Hive #5558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on #5553 |
yuqi1129
changed the title
jerryshao
reviewed
Nov 14, 2024
yuqi1129
changed the title
yuqi1129
changed the title
|
Do you need to update the PR based on #5630 ? |
yuqi1129
changed the title
jerryshao
reviewed
Nov 27, 2024
Comment on lines
134
to
135
| // You need this to run test CatalogHiveABSIT | ||
| // testImplementation(libs.hadoop3.common) |
There was a problem hiding this comment.
Is this comment still valid?
There was a problem hiding this comment.
First for Auzre Blob Storage test, it requres hadoop3 common or the following error will occur:
java.lang.NoClassDefFoundError: org/apache/hadoop/security/ssl/DelegatingSSLSocketFactory$SSLChannelMode
at org.apache.hadoop.fs.azurebfs.AzureBlobFileSystemStore.<init>(AzureBlobFileSystemStore.java:151)
at org.apache.hadoop.fs.azurebfs.AzureBlobFileSystem.initialize(AzureBlobFileSystem.java:108)
at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:3261)
at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:121)
at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:3310)
at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:3278)
at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:475)
at org.apache.gravitino.catalog.hive.integration.test.CatalogHiveABSIT.initFileSystem(CatalogHiveABSIT.java:74)
at org.apache.gravitino.catalog.hive.integration.test.CatalogHiveIT.startup(CatalogHiveIT.java:215)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725)
at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
at
If we do not comment the code, there will be conflicts between hadoop2 and hadoop3 common , resulting failures in other test.
So we need to comment the dependencies currently.
There was a problem hiding this comment.
Explain the reason why this dependency should be comment out, not just adding the confusing comment makes reviewer hard to understand.
| @@ -11,6 +11,8 @@ license: "This software is licensed under the Apache License version 2." | |||
|
|
|||
| Since Hive 2.x, Hive has supported S3 as a storage backend, enabling users to store and manage data in Amazon S3 directly through Hive. Gravitino enhances this capability by supporting the Hive catalog with S3, allowing users to efficiently manage the storage locations of files located in S3. This integration simplifies data operations and enables seamless access to S3 data from Hive queries. | |||
|
|
|||
| For ADLS (or Azure Blob storage(abs), or Azure Data lake storage(v2)), the integration is similar to S3. The only difference is the configuration properties for ADLS. The following sections will guide you through the necessary steps to configure the Hive catalog to utilize S3 as a storage backend, including configuration details and examples for creating databases and tables. | |||
There was a problem hiding this comment.
"For ADLS (aka. Azure Blob Storage (ABS), or Azure Data Lake Storage (v2)), ..."
There was a problem hiding this comment.
"S3 as a storage backend"
Is it S3 or ADLS?
jerryshao
reviewed
Nov 28, 2024
...-hive/src/test/java/org/apache/gravitino/catalog/hive/integration/test/CatalogHiveABSIT.java
Outdated
Show resolved
Hide resolved
jerryshao
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add some tests to demonstrate how to use ADLS in Hive.
Why are the changes needed?
To verify if we can use ADLS in Hive.
Fix: #5557
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Test manually.