Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix problem locating build component #2103

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

matrei
Copy link

@matrei matrei commented Jul 30, 2024

The transitive build script dependency org.jfrog.buildinfo:build-info-extractor:2.3.2 cannot be found.

This commit adds Groovy's artifactory repo to the build script repositories, to make the build find the missing dependency.

The problem started occurring in Grails groovy-joint-workflow Github action.
Error message is:

:buildSrc:compileJava NO-SOURCE
:buildSrc:compileGroovy FROM-CACHE
:buildSrc:processResources NO-SOURCE
:buildSrc:classes UP-TO-DATE
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava NO-SOURCE
:buildSrc:compileTestGroovy NO-SOURCE
:buildSrc:processTestResources NO-SOURCE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test NO-SOURCE
:buildSrc:check UP-TO-DATE
:buildSrc:build

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'groovy'.
> Could not resolve all artifacts for configuration ':classpath'.
   > Could not find org.jfrog.buildinfo:build-info-extractor:2.3.2.
     Searched in the following locations:
       - https://repo.maven.apache.org/maven2/org/jfrog/buildinfo/build-info-extractor/2.3.2/build-info-extractor-2.3.2.pom
       - https://plugins.gradle.org/m2/org/jfrog/buildinfo/build-info-extractor/2.3.2/build-info-extractor-2.3.2.pom
       - https://oss.sonatype.org/content/repositories/snapshots/org/jfrog/buildinfo/build-info-extractor/2.3.2/build-info-extractor-2.3.2.pom
       - https://jitpack.io/org/jfrog/buildinfo/build-info-extractor/2.3.2/build-info-extractor-2.3.2.pom
     Required by:
         project : > org.jfrog.buildinfo:build-info-extractor-gradle:3.0.3

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.9.4/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 20s

The transitive build script dependency `org.jfrog.buildinfo:build-info-extractor:2.3.2` cannot be found.

This commit adds Groovy's artifactory repo to the build script repositories, to make the build find the missing dependency.
@matrei
Copy link
Author

matrei commented Jul 30, 2024

Related: grails/grails-core#13573

codeconsole added a commit to codeconsole/grails-core that referenced this pull request Jul 30, 2024
codeconsole added a commit to codeconsole/grails-core that referenced this pull request Jul 30, 2024
codeconsole added a commit to codeconsole/grails-core that referenced this pull request Jul 30, 2024
codeconsole added a commit to codeconsole/grails-core that referenced this pull request Jul 30, 2024
codeconsole added a commit to codeconsole/grails-core that referenced this pull request Jul 30, 2024
@matrei
Copy link
Author

matrei commented Jul 30, 2024

I see now, that this caused another build dependency problem instead, in the "Distribute Groovy SNAPSHOT" workflow:
(should this workflow really be triggered on pull_request by the way?)

* What went wrong:
Execution failed for task ':groovy-ant:asciidoctor'.
> Could not resolve all files for configuration ':groovy-ant:asciidoctor'.
   > Could not find asciidoctorj-groovy-dsl-1.0.0.Alpha2.jar (org.asciidoctor:asciidoctorj-groovy-dsl:1.0.0.Alpha2).
     Searched in the following locations:
         https://groovy.jfrog.io/artifactory/libs-release/org/asciidoctor/asciidoctorj-groovy-dsl/1.0.0.Alpha2/asciidoctorj-groovy-dsl-1.0.0.Alpha2.jar

codeconsole added a commit to codeconsole/grails-core that referenced this pull request Jul 30, 2024
codeconsole added a commit to grails/grails-core that referenced this pull request Jul 30, 2024
@paulk-asert paulk-asert merged commit a249a1b into apache:GROOVY_3_0_X Jul 31, 2024
15 checks passed
@paulk-asert
Copy link
Contributor

paulk-asert commented Jul 31, 2024

Merged, Thanks!

The trigger on pull_request is intentional. It doesn't load the generated artifacts into the normal snapshot repo but rather builds artifacts which are available at the bottom of the action run log, e.g. scroll to the bottom of:

https://github.com/apache/groovy/actions/runs/10164041226

This makes it easier for us to test someone's PR when needed. Maybe "Generate Groovy SNAPSHOT" would be a better name than "Distribute Groovy SNAPSHOT".

P.S.: We have a different CI job that actually pushes real snapshot artifacts to the real snapshot repo.

@matrei matrei deleted the matrei/missing-build-dep branch July 31, 2024 07:02
matrei added a commit to grails/grails-core that referenced this pull request Jul 31, 2024
…rged"

This reverts commit 49eb631.

As the problem with the Groovy build is now patched, this workaround can be removed.

Related: #13578, apache/groovy#2103
sdelamo pushed a commit to grails/grails-core that referenced this pull request Aug 16, 2024
…rged" (#13580)

This reverts commit 49eb631.

As the problem with the Groovy build is now patched, this workaround can be removed.

Related: #13578, apache/groovy#2103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants