Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the [Threshold Rule] Form. #2190

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Conversation

kerwin612
Copy link
Member

What's changed?

before:
89d1a4e005dca6be0330a5a26a0f333

after:
a6737cabfae20686061574e63ef2893

When the [Metric Target] is set as [Monitor Availability], the [Threshold Rule] belongs to an invalid field (it is currently displayed but cannot be edited), so it should not be shown.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@github-actions github-actions bot added the webapp label Jul 4, 2024
@tomsun28 tomsun28 added the good first pull request Good for newcomers label Jul 4, 2024
@tomsun28 tomsun28 added this to the 1.6.1 milestone Jul 4, 2024
@tomsun28 tomsun28 merged commit 20f3b01 into apache:master Jul 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants