-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: partition table query optimize #1594
feat: partition table query optimize #1594
Conversation
}, | ||
provider::TableScanBuilder, | ||
remote::model::TableIdentifier, | ||
table::ReadRequest, | ||
}; | ||
|
||
use super::partitioned_predicates; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our codebase should prefer absolute import over super import.
let mut partitions = BTreeSet::new(); | ||
// Retrieve all the key DatumView instances along with their corresponding | ||
// indices related to their positions in the predicate inlist. Since DatumView |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
horaedb/src/common_types/src/datum.rs
Line 1313 in e065ba7
impl<'a> std::hash::Hash for DatumView<'a> { |
DatumView already impl Hash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This BTreeSet in PartitionedFilterKeyIndex is used to deduplicate the inlist key value that contributes to the partition calculation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
}, | ||
BuildPartitionRule, PartitionInfo, Result, | ||
}; | ||
|
||
mod extractor; | ||
|
||
pub type PartitionId = usize; // partiton number (id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for comments, it make the code more readable!
Rationale
Close #1441
Detailed Changes
TLDR
The performance issue with inlist queries is due to the extra overhead from bloom-filter-like directory lookups when scanning each SST file for rows. The solution is to create a separate predicate for each partition, containing only the keys relevant to that partition. Since the current partition filter only supports BinaryExpr(Column, operator, Literal) and non-negated InList expressions, this solution will address only those specific cases.
Changes
e.g.
conditions:
and with two partitions
"cc", "dd")
partition expectations:
yield two predicates
p0: col1 = '33' and col2 in ("aa", "bb", "cc");
p1: col1 = '33' and col2 in ("dd")
Other issues discovered
When the inlist key args length is less than three, Expr will be refactored to nested BinaryExpr which bypasses the FilterExtractor.
e.g.
SQL: select * from table where col1 in ("aa", "bb") and col2 in (1,2,3,4,5...1000)
Since ("aa", "bb") has fewer than three elements, the col1 key filter is not included in partition computation, which interrupts the partitioning process in the get_candidate_partition_keys_groups function, as contains_empty_filter is set to true.
Test Plan