Skip to content

Commit

Permalink
Update baseline gradle plugin to 5.58.0
Browse files Browse the repository at this point in the history
Among other things, this pulls newest version of error-prone which adds
new useful checks.
  • Loading branch information
findepi committed Jun 20, 2024
1 parent f0971da commit 16c764f
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
10 changes: 10 additions & 0 deletions baseline.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,17 @@ subprojects {
'-Xep:CollectionUndefinedEquality:ERROR',
// specific to Palantir - Uses name `log` but we use name `LOG`
'-Xep:ConsistentLoggerName:OFF',
// TODO this is a recently added check. Figure out whether we adjust the code or suppress for good
'-Xep:DangerousJavaDeserialization:WARN',
'-Xep:DangerousThreadPoolExecutorUsage:OFF',
// subclasses are not equal
'-Xep:EqualsGetClass:OFF',
// specific to Palantir
'-Xep:FinalClass:OFF',
// TODO this is a recently added check. Figure out whether we adjust the code or suppress for good
'-Xep:FormatStringAnnotation:WARN',
// TODO this is a recently added check. Figure out whether we adjust the code or suppress for good
'-Xep:ImmutablesReferenceEquality:WARN',
'-Xep:IntLongMath:ERROR',
// prefer method references over lambdas
'-Xep:LambdaMethodReference:ERROR',
Expand All @@ -94,6 +100,8 @@ subprojects {
'-Xep:MissingSummary:ERROR',
// Enforce hashCode over hash
'-Xep:ObjectsHashCodeUnnecessaryVarargs:ERROR',
// Triggers false-positives whenever relocated @VisibleForTesting is used
'-Xep:PreferCommonAnnotations:OFF',
// specific to Palantir
'-Xep:PreferSafeLoggableExceptions:OFF',
'-Xep:PreferSafeLogger:OFF',
Expand All @@ -111,6 +119,8 @@ subprojects {
'-Xep:StringSplitter:ERROR',
'-Xep:TypeParameterShadowing:OFF',
'-Xep:TypeParameterUnusedInFormals:OFF',
// Palantir's UnnecessarilyQualified may throw during analysis
'-Xep:UnnecessarilyQualified:OFF',
)
}
}
Expand Down
7 changes: 1 addition & 6 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,7 @@ buildscript {
}
dependencies {
classpath 'com.github.johnrengelman:shadow:8.1.1'
classpath 'com.palantir.baseline:gradle-baseline-java:4.42.0'
// com.palantir.baseline:gradle-baseline-java:4.42.0 (the last version supporting Java 8) pulls
// in an old version of the errorprone, which doesn't work w/ Gradle 8, so bump errorpone as
// well.
classpath "net.ltgt.gradle:gradle-errorprone-plugin:3.1.0"

classpath 'com.palantir.baseline:gradle-baseline-java:5.58.0'
classpath 'com.diffplug.spotless:spotless-plugin-gradle:6.13.0'
classpath 'gradle.plugin.org.inferred:gradle-processors:3.7.0'
classpath 'me.champeau.jmh:jmh-gradle-plugin:0.7.2'
Expand Down

0 comments on commit 16c764f

Please sign in to comment.