This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Replaces keys.yaml and Keys with Key enum #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 1, 2017 17:04
kramasamy
approved these changes
Feb 3, 2017
| @@ -33,8 +33,7 @@ private LocalDefaults() { | |||
| static { | |||
| try { | |||
| defaults = Resource.load( | |||
| "com.twitter.heron.scheduler.local.LocalDefaults", | |||
| LocalConstants.DEFAULTS_YAML); | |||
| "com.twitter.heron.scheduler.local.LocalDefaults", DEFAULTS_YAML); | |||
There was a problem hiding this comment.
Just wondering if this is needed?
There was a problem hiding this comment.
This will be refactored out in a follow-up that addresses defaults.
|
code LGTM. CI integration test fails. |
|
That integration test is failing, but we should be able to merge this PR. I have some PRs waiting this to be merged. |
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
* Clean up config visiblity and dead code * Change to use getStringValue instead of get * Replace keys.yaml with Key enum * revert change from this review * Migrate all files to use Key enum for configs instead of keys.yaml * Fixed typo where scheduler config was being overwritten
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Replaces prototype PR at billonahill#5 with the full refactor)
Refactoring to no longer read keys from
keys.yaml. All key usage is viaKeyenum and removingkeys.yamlandKeys. Core classes in this review areKeyandConfig. All others are refactors to use changes to those two classes.Benefits:
keys.yamlKeymetadata (e.g., type, default, required, etc)After this I'd like to also remove
defaults.yamlin favor of the enum approach.