This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 593
clean up site docs #3626
Merged
joshfischer1108
merged 8 commits into
apache:master
from
joshfischer1108:joshfischer/clean-up-site
Oct 31, 2020
Merged
clean up site docs #3626
joshfischer1108
merged 8 commits into
apache:master
from
joshfischer1108:joshfischer/clean-up-site
Oct 31, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code0x58
reviewed
Oct 30, 2020
@@ -181,8 +181,7 @@ $ heron submit local \ | |||
Note the `-` in this submission command. If you define a topology by subclassing `TopologyBuilder` you do not need to instruct Heron where your main method is located. | |||
|
|||
> #### Example topologies buildable as PEXs | |||
> * See [this repo](https://github.com/streamlio/pants-dev-environment) for an example of a Heron topology written in Python and deployable as a Pants-packaged PEX. | |||
> * See [this repo](https://github.com/streamlio/bazel-dev-environment) for an example of a Heron topology written in Python and deployable as a Bazel-packaged PEX. | |||
> TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@windhamwong. do you have any ideas/thoughts on this area?
website2/website/versioned_docs/version-0.20.0-incubating/guides-python-topologies.md
Show resolved
Hide resolved
Co-authored-by: Oliver Bristow <[email protected]>
…8/incubator-heron into joshfischer/clean-up-site
Code0x58
reviewed
Oct 30, 2020
website2/website/versioned_docs/version-0.20.2-incubating/compiling-code-organization.md
Outdated
Show resolved
Hide resolved
Code0x58
approved these changes
Oct 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - a good chunk of work on sanitising the docs!
Yessir. Thank you for taking the time to review. |
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to add some website clean up on the documentation.. Mainly removing dead links. More to come.