Python rules for Bazel

WORKSPACE

@@ -179,9 +179,17 @@ http_archive(
     url = "https://github.com/bazelbuild/rules_python/releases/download/0.1.0/rules_python-0.1.0.tar.gz",
 )
 
+load("@rules_python//python:pip.bzl", "pip_install")
+# Create a central external repo, @heron_py_deps, that contains Bazel targets for all the
+# third-party packages specified in the requirements.txt file.
+pip_install(
+   name = "heron_py_deps",
+   requirements = "//tools/python:requirements.txt",
+)
+
 load("@rules_python//python:repositories.bzl", "py_repositories")
 
-py_repositories()
+#py_repositories()
 # Only needed if using the packaging rules.
 # load("@rules_python//python:pip.bzl", "pip_repositories")
 # pip_repositories()
@@ -399,7 +407,6 @@ http_archive(
 # end helm
 
 # for docker image building
-
 http_archive(
     name = "io_bazel_rules_docker",
     sha256 = "59536e6ae64359b716ba9c46c39183403b01eabfbd57578e84398b4829ca499a",
@@ -417,10 +424,6 @@ load("@io_bazel_rules_docker//repositories:deps.bzl", container_deps = "deps")
 
 container_deps()
 
-load("@io_bazel_rules_docker//repositories:py_repositories.bzl", "py_deps")
-
-py_deps()
-
 load(
     "@io_bazel_rules_docker//container:container.bzl",
     "container_pull",

examples/src/python/BUILD

@@ -1,6 +1,9 @@
 package(default_visibility = ["//visibility:public"])
 
-pex_library(
+load("@rules_python//python:defs.bzl", "py_library")
+load("@rules_python//python:defs.bzl", "py_binary")
+
+py_library(
     name = "example-py",
     srcs = glob([
         "bolt/*.py",
@@ -13,45 +16,45 @@ pex_library(
 )
 
 # with main method
-pex_binary(
+py_binary(
     name = "word_count",
     srcs = ["word_count_topology.py"],
     deps = [":example-py"],
 )
 
-pex_binary(
+py_binary(
     name = "half_acking",
     srcs = ["half_acking_topology.py"],
     deps = [":example-py"],
 )
 
-pex_binary(
+py_binary(
     name = "window_size",
     srcs = ["window_size_topology.py"],
     deps = [":example-py"],
 )
 
-pex_binary(
+py_binary(
     name = "stateful_word_count",
     srcs = ["stateful_word_count_topology.py"],
     deps = [":example-py"],
 )
 
 # without main method
-pex_binary(
+py_binary(
     name = "custom_grouping",
     srcs = ["custom_grouping_topology.py"],
     deps = [":example-py"],
 )
 
-pex_binary(
+py_binary(
     name = "multi_stream",
     srcs = ["multi_stream_topology.py"],
     deps = [":example-py"],
 )
 
 # streamlet API examples
-pex_binary(
+py_binary(
     name = "word_count_streamlet",
     srcs = ["word_count_streamlet.py"],
     deps = [
@@ -61,7 +64,7 @@ pex_binary(
     ],
 )
 
-pex_binary(
+py_binary(
     name = "pulsar_word_count_streamlet",
     srcs = ["pulsar_word_count_streamlet.py"],
     deps = [
@@ -71,7 +74,7 @@ pex_binary(
     ],
 )
 
-pex_binary(
+py_binary(
     name = "join_streamlet_topology",
     srcs = ["join_streamlet_topology.py"],
     deps = [

heron/common/src/python/BUILD

@@ -1,12 +1,13 @@
 package(default_visibility = ["//visibility:public"])
 
-pex_library(
+load("@rules_python//python:defs.bzl", "py_library")
+load("@heron_py_deps//:requirements.bzl", "requirement")
+
+py_library(
     name = "common-py",
     srcs = glob(["**/*.py"]),
-    reqs = [
-        "colorlog==2.6.1",
-    ],
     deps = [
         "//heron/proto:proto-py",
+        requirement("colorlog")
     ],
 )

heron/common/tests/python/pex_loader/testdata/src/BUILD

@@ -1,6 +1,7 @@
 package(default_visibility = ["//visibility:public"])
 
-pex_binary(
+py_binary(
     name = "sample_pex",
+    main = "sample.py",
     srcs = ["sample.py"],
 )

heron/executor/src/python/BUILD

@@ -1,19 +1,27 @@
 package(default_visibility = ["//visibility:public"])
 
-pex_library(
+load("@rules_python//python:defs.bzl", "py_library")
+load("@rules_python//python:defs.bzl", "py_binary")
+load("@heron_py_deps//:requirements.bzl", "requirement")
+
+py_library(
     name = "executor-py",
     srcs = ["heron_executor.py"],
-    reqs = ["PyYAML==5.4.1", "click==7.1.2"],
     deps = [
         "//heron/common/src/python:common-py",
         "//heron/statemgrs/src/python:statemgr-py",
+        requirement("PyYAML"),
+        requirement("click"),
+
     ],
 )
 
-pex_binary(
+py_binary(
     name = "heron-executor",
     srcs = ["heron_executor.py"],
     deps = [
         ":executor-py",
     ],
 )
+
+

heron/instance/src/python/BUILD

@@ -1,6 +1,10 @@
 package(default_visibility = ["//visibility:public"])
 
-pex_library(
+load("@rules_python//python:defs.bzl", "py_library")
+load("@rules_python//python:defs.bzl", "py_binary")
+load("@heron_py_deps//:requirements.bzl", "requirement")
+
+py_library(
     name = "instance-py",
     srcs = glob(["**/*.py"]),
     deps = [
@@ -13,13 +17,19 @@ pex_library(
 )
 
 # build binary for single thread python heron instance
-pex_binary(
+py_binary(
     name = "heron-python-instance",
     srcs = ["instance.py"],
-    reqs = [
-        "PyYAML==5.4.1",
-        "click==7.1.2",
-        "colorlog==2.6.1",
+    deps = [
+        ":instance-py",
+        requirement("PyYAML"),
+        requirement("click"),
+        requirement("colorlog"),
     ],
-    deps = [":instance-py"],
 )
+
+
+
+
+
+

heron/instance/tests/python/BUILD

@@ -1,13 +1,14 @@
 package(default_visibility = ["//visibility:public"])
 
-pex_library(
+load("@rules_python//python:defs.bzl", "py_library")
+load("@heron_py_deps//:requirements.bzl", "requirement")
+
+py_library(
     name = "instance-tests-py",
     srcs = ["mock_protobuf.py"],
-    reqs = [
-        "pytest==6.1.2",
-    ],
     deps = [
         "//heron/proto:proto-py",
         "//heronpy/api:heron-python-py",
+        requirement("pytest"),
     ],
 )

heron/instance/tests/python/network/BUILD

@@ -1,20 +1,19 @@
 package(default_visibility = ["//visibility:public"])
 
-pex_library(
+load("@rules_python//python:defs.bzl", "py_library")
+load("@heron_py_deps//:requirements.bzl", "requirement")
+
+py_library(
     name = "instance-network-mock",
     srcs = ["mock_generator.py"],
-    reqs = [
-    ],
     deps = [
         "//heron/instance/tests/python:instance-tests-py",
     ],
 )
 
-pex_library(
+py_library(
     name = "instance-network-mock-client",
     srcs = ["mock_generator_client.py"],
-    reqs = [
-    ],
     deps = [
         "//heron/instance/tests/python:instance-tests-py",
     ],
@@ -48,14 +47,12 @@ pex_pytest(
     ],
 )
 
-pex_library(
+py_library(
     name = "pytest-network-py",
     srcs = ["mock_generator.py"],
-    reqs = [
-        "pytest==6.1.2",
-    ],
     deps = [
         ":instance-network-mock-client",
+        requirement("pytest"),
     ],
 )
 

heron/instance/tests/python/utils/BUILD

@@ -1,10 +1,10 @@
 package(default_visibility = ["//visibility:public"])
 
-pex_library(
+load("@rules_python//python:defs.bzl", "py_library")
+
+py_library(
     name = "common-utils-mock",
     srcs = ["mock_generator.py"],
-    reqs = [
-    ],
     deps = [
         "//heron/instance/src/python:instance-py",
         "//heron/instance/tests/python:instance-tests-py",

heron/proto/BUILD

@@ -2,6 +2,9 @@ load("//tools/rules:genproto.bzl", "proto_library")
 load("@rules_java//java:defs.bzl", "java_library")
 load("@rules_cc//cc:defs.bzl", "cc_library")
 
+load("@rules_python//python:defs.bzl", "py_library")
+load("@heron_py_deps//:requirements.bzl", "requirement")
+
 package(default_visibility = ["//visibility:public"])
 
 filegroup(
@@ -178,12 +181,8 @@ java_library(
     ],
 )
 
-pex_library(
+py_library(
     name = "proto-py",
-    reqs = [
-        "protobuf==3.14.0",
-        "setuptools==51.0.0",
-    ],
     deps = [
         ":proto_ckptmgr_py",
         ":proto_common_py",
@@ -197,6 +196,8 @@ pex_library(
         ":proto_tmanager_py",
         ":proto_topology_py",
         ":proto_tuple_py",
+        requirement("protobuf"),
+        requirement("setuptools"),
     ],
 )
 

heron/shell/src/python/BUILD

@@ -1,24 +1,25 @@
 package(default_visibility = ["//visibility:public"])
 
-pex_library(
+load("@rules_python//python:defs.bzl", "py_library")
+load("@rules_python//python:defs.bzl", "py_binary")
+load("@heron_py_deps//:requirements.bzl", "requirement")
+
+py_library(
     name = "heron-shell-lib",
-    srcs = glob(
-        ["**/*.py"],
-    ),
-    reqs = [
-        "logging-formatter-anticrlf==1.2",
-        "requests==2.27.1",
-        "tornado==6.1",
-    ],
+    srcs = glob(["**/*.py"]),
     deps = [
         "//heron/common/src/python:common-py",
+        requirement("logging-formatter-anticrlf"),
+        requirement("requests"),
+        requirement("tornado"),
     ],
 )
 
-pex_binary(
+py_binary(
     name = "heron-shell",
+    main = "main.py",
     srcs = ["main.py"],
-    resources = [
+    data = [
         "//heron/shell/assets",
     ],
     deps = [

heron/statemgrs/src/python/BUILD

@@ -1,14 +1,17 @@
 package(default_visibility = ["//visibility:public"])
 
-pex_library(
+load("@rules_python//python:defs.bzl", "py_library")
+load("@heron_py_deps//:requirements.bzl", "requirement")
+
+py_library(
     name = "statemgr-py",
     srcs = glob(["**/*.py"]),
-    reqs = [
-        "PyYAML==5.4.1",
-        "kazoo==2.8.0",
-        "zope.interface==4.0.5",
-    ],
     deps = [
         "//heron/proto:proto-py",
+        requirement("PyYaml"),
+        requirement("kazoo"),
+        requirement("zope.interface"),
     ],
 )
+
+