Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-tools-issues#2584: Make private members to be protected for DefaultVsCodeKieEditorChannelApiImpl #2606

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

lordrip
Copy link
Contributor

@lordrip lordrip commented Sep 20, 2024

Context

Expose constructor parameters to subclasses of the DefaultVsCodeKieEditorChannelApiImpl class.

Notes

This is not urgent by any means, so if accepted, please feel free to merge it at your best convenience.

fix: #2584

Expose constructor parameters to subclasses of the `DefaultVsCodeKieEditorChannelApiImpl` class.

fix: apache#2584
@lordrip lordrip requested a review from tiagobento as a code owner September 20, 2024 11:38
@yesamer yesamer changed the title chore(VSCode): Expose constructor parameters kie-tools-issues#2584: Make private members to be protected for DefaultVsCodeKieEditorChannelApiImpl Sep 20, 2024
Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lordrip for your contribution :)

@tiagobento tiagobento merged commit 06e97c4 into apache:main Sep 20, 2024
14 checks passed
@lordrip lordrip deleted the lordrip-patch-1 branch September 20, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make private members to be protected for DefaultVsCodeKieEditorChannelApiImpl
3 participants