Disable deprecated druid connector by default

[willbarrett]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

I've been informed by @mistercrunch that the Druid connector is deprecated in favor of the Druid SQLAlchemy engine. After a recent PR ( #8482 ) re-enabled the function of the DRUID_IS_ACTIVE flag, I figured I'd follow through and enshrine the deprecation in code by defaulting DRUID_IS_ACTIVE to False.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API (only by default, can be re-enabled)

REVIEWERS

@mistercrunch @dpgaspar @betodealmeida

[dpgaspar]

This can be a breaking change, checked docs and there is a note already but without a version target for removal. We should add a note on UPDATING.md.

Tests are failing, prob just need update, removing the now non existent permissions

[john-bodley]

@willbarrett it’s not deprecated yet, however there is merit in swaying new installations to prefer Druid SQL over the legacy native JSON-based query API. For context the deprecation of the native Druid connector is discussed in SIP-11.

[willbarrett]

Thanks for the link @john-bodley - did that SIP go through an Apache vote process? Do you know if it was approved?

[john-bodley]

@willbarrett the SIP hasn't been voted on and there was some initial push back due to non-feature parity. I know that Druid SQL is evolving but I'm uncertain whether all sketches (and other unique features) are supported.

Note for context at Airbnb we're hoping to migrate away from the native Druid connector to Druid SQL and I'm currently working on a feasibility study and documenting what needs to happen in order to migrate a chart between the connectors. I may share a sanitized version of the doc with the community.

[willbarrett]

OK. I need to think about how to handle this situation appropriately. I'm going to leave this PR as-is for a while.

[mistercrunch]

Sketches seem to be supported, check out the APPROX_* functions here: https://druid.apache.org/docs/latest/querying/sql.html

I'd still change the default, and add a line in UPDATING.md, @willbarrett this file is where we document breaking changes, or notifications that are relevant to people upgrading: https://github.com/apache/incubator-superset/blob/master/UPDATING.md

[codecov-io]

Codecov Report

Merging #8512 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #8512      +/-   ##
=========================================
- Coverage   65.76%   65.7%   -0.06%     
=========================================
  Files         482     482              
  Lines       23824   23834      +10     
  Branches     2594    2594              
=========================================
- Hits        15667   15661       -6     
- Misses       7984    8000      +16     
  Partials      173     173

Impacted Files	Coverage Δ
superset/config.py	89.86% <100%> (ø)	⬆️
superset/connectors/druid/views.py	64% <0%> (-5.34%)	⬇️
superset/views/base.py	72.27% <0%> (-0.91%)	⬇️
superset/connectors/druid/models.py	81.83% <0%> (-0.6%)	⬇️
superset/db_engine_specs/presto.py	22.58% <0%> (-0.06%)	⬇️
superset/sql_lab.py	78.03% <0%> (+0.1%)	⬆️
superset/app.py	80.13% <0%> (+1.15%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acf0753...f2d0d3a. Read the comment docs.

[john-bodley]

@willbarret apologies for not mentioning this sooner but can we rename this to something more specific, i.e., DRUID_NATIVE_IS_ACTIVE or DRUID_NOSQL_IS_ACTIVE?