Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
The
DRUID_IS_ACTIVE
configuration option was removed from the codebase at some point. Druid's preferred connection method is via the SQL interface, so this change is necessary in order to deprecate the Druid API-based connection methods in Superset.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
DRUID_IS_ACTIVE
set toTrue
, ensure Druid options appear in the "Sources" menu.DRUID_IS_ACTIVE
set toFalse
, ensure Druid options are absent from the "Sources" menu.ADDITIONAL INFORMATION
REVIEWERS
@mistercrunch @dpgaspar