Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix c++ compile error. #10152

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Fix c++ compile error. #10152

merged 1 commit into from
Jun 15, 2023

Conversation

ChaomingZhangCN
Copy link
Contributor

Description

[Bug] One of the constructors for the Tablet class in the client-cpp interface is incorrect #10050


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this is your first pull request in IoTDB project. Thanks for your contribution! IoTDB will be better because of you.

@LoopJump
Copy link
Contributor

@Zhangchaoming thanks for your contribution.

This PR looks good to me.

@HTHou please check if this PR can be merged.

@HTHou HTHou merged commit ebfedc1 into apache:master Jun 15, 2023
THUMarkLau pushed a commit that referenced this pull request Jun 20, 2023
@ChaomingZhangCN ChaomingZhangCN deleted the fix-bug branch February 22, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants