Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new plan optimizer: PredicatePushDown #11859

Merged
merged 79 commits into from
Feb 29, 2024

Conversation

liuminghui233
Copy link
Member

In this PR, I implement new plan optimizer: PredicatePushDown.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 671 lines in your changes are missing coverage. Please review.

Comparison is base (96929fa) 48.96% compared to head (db91b19) 49.63%.
Report is 40 commits behind head on master.

Files Patch % Lines
...tor/predicate/ConvertPredicateToFilterVisitor.java 0.00% 157 Missing ⚠️
...ueryengine/plan/planner/OperatorTreeGenerator.java 11.47% 108 Missing ⚠️
...ression/visitor/predicate/PredicateSimplifier.java 33.33% 80 Missing ⚠️
...isitor/predicate/PredicatePushIntoScanChecker.java 0.00% 42 Missing ⚠️
...eryengine/plan/optimization/PredicatePushDown.java 81.25% 36 Missing ⚠️
...tdb/db/queryengine/plan/analyze/TemplatedInfo.java 0.00% 28 Missing ⚠️
...ne/execution/operator/process/ProjectOperator.java 0.00% 22 Missing ⚠️
...n/expression/visitor/logical/LogicalOrVisitor.java 0.00% 17 Missing ⚠️
...ngine/plan/planner/plan/node/PlanGraphPrinter.java 27.27% 16 Missing ⚠️
.../expression/visitor/logical/LogicalAndVisitor.java 17.64% 14 Missing ⚠️
... and 45 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11859      +/-   ##
============================================
+ Coverage     48.96%   49.63%   +0.66%     
- Complexity    25727    26265     +538     
============================================
  Files          2910     2929      +19     
  Lines        182212   183463    +1251     
  Branches      21837    22057     +220     
============================================
+ Hits          89222    91062    +1840     
+ Misses        92990    92401     -589     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@JackieTien97 JackieTien97 merged commit b93cd04 into master Feb 29, 2024
36 of 37 checks passed
@JackieTien97 JackieTien97 deleted the lmh/PredicatePushDown branch February 29, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants