Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache clusterId in IoTDBConfig #12053

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Cache clusterId in IoTDBConfig #12053

merged 7 commits into from
Feb 28, 2024

Conversation

liyuheng55555
Copy link
Collaborator

IoTDBDescriptor.getInstance().getConfig().getClusterId()

@SteveYurongSu SteveYurongSu self-requested a review February 20, 2024 02:24
Caideyipi
Caideyipi approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@Caideyipi Caideyipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

OneSizeFitsQuorum
OneSizeFitsQuorum approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wangchao316
wangchao316 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@wangchao316 wangchao316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyuheng55555 liyuheng55555 force-pushed the Working/clusterId_cache branch from e342911 to 4d1c909 Compare February 27, 2024 08:11
OneSizeFitsQuorum
OneSizeFitsQuorum reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@OneSizeFitsQuorum OneSizeFitsQuorum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These codes will be optimized in next PR.

while (configManager.getConsensusManager() == null)

@OneSizeFitsQuorum OneSizeFitsQuorum merged commit c3c48a2 into apache:master Feb 28, 2024
34 of 36 checks passed
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
@liyuheng55555 @SzyWilliam
Cache clusterId in IoTDBConfig (apache#12053)
aad9b1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OneSizeFitsQuorum OneSizeFitsQuorum OneSizeFitsQuorum approved these changes

@Caideyipi Caideyipi Caideyipi approved these changes

@wangchao316 wangchao316 wangchao316 approved these changes

@SteveYurongSu SteveYurongSu SteveYurongSu approved these changes

@CRZbulabula CRZbulabula Awaiting requested review from CRZbulabula

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liyuheng55555 @SteveYurongSu @OneSizeFitsQuorum @wangchao316 @Caideyipi