Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe: fixed potential lose point bug caused by cancelled flush of historical extractor #12056

Merged
merged 10 commits into from
Feb 21, 2024

Conversation

Caideyipi
Copy link
Collaborator

Description

As the title said.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@Caideyipi Caideyipi changed the title Pipe: fixed potential lose point bug caused by cancelled flush by historical extractor Pipe: fixed potential lose point bug caused by cancelled flush of historical extractor Feb 20, 2024
@SteveYurongSu SteveYurongSu self-assigned this Feb 20, 2024
@SteveYurongSu SteveYurongSu self-requested a review February 20, 2024 11:22
@SteveYurongSu SteveYurongSu merged commit a67b0c0 into apache:master Feb 21, 2024
36 checks passed
HTHou pushed a commit that referenced this pull request Mar 5, 2024
…torical extractor (#12056)

The data loss situation can be caused by the following operations:
 1. PipeA: start historical data extraction with flush
 2. Data insertion
 3. PipeB: start realtime data extraction
 4. PipeB: start historical data extraction without flush
 5. Data inserted in the step2 is not captured by PipeB, and if its tsfile epoch's state is USING_TABLET, the tsfile event will be ignored, which will cause the data loss in the tsfile epoch.

---------

Co-authored-by: Steve Yurong Su <[email protected]>
SzyWilliam pushed a commit to SzyWilliam/iotdb that referenced this pull request Nov 26, 2024
…torical extractor (apache#12056)

The data loss situation can be caused by the following operations:
 1. PipeA: start historical data extraction with flush
 2. Data insertion
 3. PipeB: start realtime data extraction
 4. PipeB: start historical data extraction without flush
 5. Data inserted in the step2 is not captured by PipeB, and if its tsfile epoch's state is USING_TABLET, the tsfile event will be ignored, which will cause the data loss in the tsfile epoch.

---------

Co-authored-by: Steve Yurong Su <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants