Skip to content

Commit

Permalink
MINOR: Fix PerformanceService sys test (#18797)
Browse files Browse the repository at this point in the history
This patch fixes the PerformanceService system test which was still using ZK.

```
================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.12.0
session_id:       2025-02-04--003
run time:         1 minute 42.629 seconds
tests run:        4
passed:           4                                                                                                                                                                         flaky:            0
failed:           0                                                                                                                                                                         ignored:          0
================================================================================
```

Reviewers: Chia-Ping Tsai <[email protected]>
  • Loading branch information
dajac authored Feb 4, 2025
1 parent 17d1447 commit 4c6af67
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions tests/kafkatest/sanity_checks/test_performance_services.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
from kafkatest.services.kafka import KafkaService, quorum
from kafkatest.services.performance import ProducerPerformanceService, ConsumerPerformanceService, EndToEndLatencyService
from kafkatest.services.performance import latency, compute_aggregate_throughput
from kafkatest.services.zookeeper import ZookeeperService
from kafkatest.version import DEV_BRANCH, LATEST_2_1, KafkaVersion


Expand All @@ -31,14 +30,8 @@ def __init__(self, test_context):
self.num_records = 10000
self.topic = "topic"

self.zk = ZookeeperService(test_context, 1) if quorum.for_test(test_context) == quorum.zk else None

def setUp(self):
if self.zk:
self.zk.start()

@cluster(num_nodes=5)
@matrix(version=[str(LATEST_2_1), str(DEV_BRANCH)], metadata_quorum=quorum.all)
@matrix(version=[str(LATEST_2_1), str(DEV_BRANCH)], metadata_quorum=quorum.all_kraft)
def test_version(self, version=str(LATEST_2_1), metadata_quorum=quorum.zk):
"""
Sanity check out producer performance service - verify that we can run the service with a small
Expand All @@ -47,7 +40,7 @@ def test_version(self, version=str(LATEST_2_1), metadata_quorum=quorum.zk):
version = KafkaVersion(version)
self.kafka = KafkaService(
self.test_context, 1,
self.zk, topics={self.topic: {'partitions': 1, 'replication-factor': 1}}, version=DEV_BRANCH)
None, topics={self.topic: {'partitions': 1, 'replication-factor': 1}}, version=DEV_BRANCH)
self.kafka.start()

# check basic run of producer performance
Expand Down

0 comments on commit 4c6af67

Please sign in to comment.