-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-3451: Add basic HTML coverage report generation to gradle #1121
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -452,12 +452,13 @@ class ZkUtils(val zkClient: ZkClient, | |
} catch { | ||
case e1: ZkBadVersionException => | ||
optionalChecker match { | ||
case Some(checker) => return checker(this, path, data) | ||
case _ => debug("Checker method is not passed skipping zkData match") | ||
case Some(checker) => checker(this, path, data) | ||
case _ => | ||
debug("Checker method is not passed skipping zkData match") | ||
warn("Conditional update of path %s with data %s and expected version %d failed due to %s" | ||
.format(path, data,expectVersion, e1.getMessage)) | ||
(false, -1) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note: This minimal change was made because the old "style" broke the Scoverage code instrumentation. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's a bit concerning that valid Scala code breaks scoverage. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. On the bright side, it encourages better coding practice. ;) |
||
} | ||
warn("Conditional update of path %s with data %s and expected version %d failed due to %s".format(path, data, | ||
expectVersion, e1.getMessage)) | ||
(false, -1) | ||
case e2: Exception => | ||
warn("Conditional update of path %s with data %s and expected version %d failed due to %s".format(path, data, | ||
expectVersion, e2.getMessage)) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually seem necessary based on the couple of targets I built? I'm not even sure what dependencies needed this? Same is true of the
jcenter()
reference atbuildscript
level, although that wasn't introduced in this patch.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will double check and remove it if its not needed.