MINOR: Documentation improvements for dynamic quorums #17810
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing dynamic quorums, I ran into a few issues that might be mitigated by improved docs, specifically around the semantics of dynamic quorums. This adds a small summary to the new features, where this is added.
The biggest thing I ran into is that 3.8 and below disallowed controller listeners being included in
advertised.listeners, and 3.9 allows controller listeners in theadvertised.listeners. Not only that, advertised listeners are effectively required to communicate with dynamically-added controllers.Committer Checklist (excluded from commit message)