Gracefully close kyuubi & add custom labels #6892
Open
+36
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6892 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 688 688
Lines 42590 42590
Branches 5805 5805
======================================
Misses 42590 42590 ☔ View full report in Codecov by Sentry. |
turboFei
reviewed
Jan 15, 2025
| command: ['sh', '-c', "echo \"ok!!!\""] | ||
| preStop: | ||
| exec: | ||
| command: ["/bin/sh","-c","/opt/kyuubi/bin/kyuubi-ctl delete server --host $(hostname -I) --port \"10009\""] |
|
ping @dnskr |
dnskr
requested changes
Jan 15, 2025
There was a problem hiding this comment.
@HYBG-1126 Thank you for the PR!
Could you please add the description following the template to provide more context for the suggested changes?
Also, please fix a typo in the PR title and the commit message (customer should be custom).
HYBG-1126
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?